[
https://issues.apache.org/jira/browse/BOOKKEEPER-608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13650610#comment-13650610
]
Hadoop QA commented on BOOKKEEPER-608:
--------------------------------------
Testing JIRA BOOKKEEPER-608
Patch
[0001-BOOKKEEPER-608-Move-syncthread-out-of-bookie.patch|https://issues.apache.org/jira/secure/attachment/12581880/0001-BOOKKEEPER-608-Move-syncthread-out-of-bookie.patch]
downloaded at Tue May 7 08:13:55 UTC 2013
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
120
. {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
{color:green}+1 TESTS{color}
. Tests run: 836
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:green}*+1 Overall result, good!, no -1s*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/334/
> Make SyncThread a reusable component
> ------------------------------------
>
> Key: BOOKKEEPER-608
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-608
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.3.0
>
> Attachments: 0001-BOOKKEEPER-608-Move-syncthread-out-of-bookie.patch
>
>
> The sync thread is currently a inner class of Bookie. This means it's not
> possible to test the functionality of the sync thread and ledger storage
> without creating a full bookie, and when you do that you also have to create
> a journal etc.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
