[
https://issues.apache.org/jira/browse/BOOKKEEPER-257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13652839#comment-13652839
]
Ivan Kelly commented on BOOKKEEPER-257:
---------------------------------------
Patch looks good. The @return javadoc should have a description or not be there
at all. Likewise with the throws, @throws IOException doesn't add any more
information that the javadoc tool cannot infer from the declaration. It would
be better to specify as,
{code}
/**
* Get the list of available ledgers
* @return an iterable list of ledger ids
* @throws IOException if the ledger id list cannot be read from metadata
storage
*/
{code}
Also, there's a lot of trailing whitespace. It should be possible to have
eclipse automatically remove this in the lines you modify.
> Ability to list all ledgers
> ---------------------------
>
> Key: BOOKKEEPER-257
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-257
> Project: Bookkeeper
> Issue Type: New Feature
> Reporter: Ivan Kelly
> Assignee: Flavio Junqueira
> Fix For: 4.3.0
>
> Attachments: BOOKKEEPER-257.patch, BOOKKEEPER-257.patch
>
>
> When an application is using bookkeeper it must keep a copy of the ledger ids
> it creates so that they can be used later, and once they are no longer
> useful, deleted. However, in the case of a crash between ledger creation and
> persisting the application copy of the id, the ledger will be dangling.
> Therefore I propose we have the ability to get a list of all ledger ids,
> which clients can use for garbage collection. However, I don't think it
> should be part of the BookKeeper class, rather part of a new BookKeeperAdmin
> class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
