[
https://issues.apache.org/jira/browse/BOOKKEEPER-610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13657203#comment-13657203
]
Ivan Kelly edited comment on BOOKKEEPER-610 at 5/14/13 5:07 PM:
----------------------------------------------------------------
In fact, the current SyncThread implementation doesn't necessarily run flush on
shutdown. Most likely it will not be called. The only time flush can be called
is if shutdown() is called between the flushing.compareAndSet and the call to
checkpoint. Otherwise it will break out of the thread.
was (Author: ikelly):
In fact, the current SyncThread implementation doesn't necessarily run
flush on shutdown. Most likely it will not be. The only time flush can be
called is if shutdown() is called between the flushing.compareAndSet and the
call to checkpoint. Otherwise it will break out of the thread.
> Make SyncThread use an executor
> -------------------------------
>
> Key: BOOKKEEPER-610
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-610
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.3.0
>
> Attachments:
> 0001-BOOKKEEPER-610-Make-SyncThread-use-an-executor.patch,
> 0001-BOOKKEEPER-610-Make-SyncThread-use-an-executor.patch,
> 0001-BOOKKEEPER-610-Make-SyncThread-use-an-executor.patch
>
>
> Currently we have a bunch of boolean variables to control the lifecycle of
> the SyncThread. We're effectively replicating what an Executor does, so we
> should just use an executor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
