[
https://issues.apache.org/jira/browse/BOOKKEEPER-563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13679513#comment-13679513
]
Ivan Kelly commented on BOOKKEEPER-563:
---------------------------------------
The patch is backwards(removes the feature rather than adds it), so it needs to
be generated again. I also have 3 small comments.
1) There's a getJournalRemovePagesFromCache() in server config but no set. We
should have a set to be consistent (also have it return a ServerConfiguration
object to allow chaining)
2) Is System.getProperty("os.name").toLowerCase().contains("linux") necessary?
posix_fadvise is posix, so any system that has it should be compatible, any
that doesn't should throw a link error.
3) catch should be on the same line as the previous }.
> Avoid Journal polluting page cache
> ----------------------------------
>
> Key: BOOKKEEPER-563
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-563
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Sijie Guo
> Assignee: Robin Dhamankar
> Fix For: 4.3.0
>
> Attachments: BOOKKEEPER-563.diff
>
>
> writing data into journal which force the data in os buffer cache being used
> for hot reads, which could have negative affect on performance.
> similar solution is as CASSANDRA-1470.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
