[
https://issues.apache.org/jira/browse/BOOKKEEPER-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13680999#comment-13680999
]
Sijie Guo commented on BOOKKEEPER-623:
--------------------------------------
first of all, I don't think the fix addresses your issue described. in this
case, if entry 10 has auth failure and the ledger closed in entry 9. so when
the ledger is opened to read, we just could access entries until 9. the
semantic is correct and consistent. the extra segment doesn't affect the
semantic of a closed ledger. so it is a auto-recovery issue not an error
handling issue here.
second, the segment is added when changing ensemble before closing. so how the
close checking avoid adding extra segment? third, I don't think you need to add
metadata.isClosed checking, since any zookeeper update is conditional and
LedgerMetadata#resolveConflict already check if the metadata is Closed or not.
so I am doubting how your test case reproduce your comment. Could you make it
clear?
> Metadata is having extra Segment which is causing AutoRecovery to fail
> ----------------------------------------------------------------------
>
> Key: BOOKKEEPER-623
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-623
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-server
> Affects Versions: 4.2.1, 4.3.0
> Reporter: Vinay
> Assignee: Vinay
> Fix For: 4.3.0
>
> Attachments: BOOKKEEPER-623.patch, BOOKKEEPER-623.patch
>
>
> With the almost same testcase mentioned in the BOOKKEEPER-584, Ledger
> metadata is getting added with extra segment during failure handling of
> bookies along with fencing.
> Only difference in the testcase is .
> 1. Before bookie failures some entries were already written
> 2. And after bookies failed ( First bookie will throw
> LedgerFenced/Unauthorized exception, and second bookie is slow/dead bookie ),
> Number of entries written asynchrounously is n*ensembleSize+1
> Note that, Unauthorized/FencedException callback comes first, then other
> bookie failure callback comes.
> I will attach a TestCase along with patch for this shortly. Testcase is
> modified version of attached testcase in BOOKKEEPER-584
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
