[
https://issues.apache.org/jira/browse/BOOKKEEPER-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13683870#comment-13683870
]
Hadoop QA commented on BOOKKEEPER-313:
--------------------------------------
Testing JIRA BOOKKEEPER-313
Patch
[BOOKKEEPER-313-branch-4.2.patch|https://issues.apache.org/jira/secure/attachment/12587773/BOOKKEEPER-313-branch-4.2.patch]
downloaded at Fri Jun 14 22:14:44 UTC 2013
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
120
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
{color:green}+1 TESTS{color}
. Tests run: 848
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/365/
> Bookkeeper shutdown call from Bookie thread is not shutting down server
> -----------------------------------------------------------------------
>
> Key: BOOKKEEPER-313
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-313
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-server
> Affects Versions: 4.2.1
> Reporter: Vinay
> Assignee: Vinay
> Fix For: 4.2.2
>
> Attachments: BOOKKEEPER-313-branch-4.2.patch
>
>
> shutdown(..) call from inside Bookie#run() is not shutting down the server.
> Bookie thread is waiting to join itself.
> Shutdown called from here
> {code} if (!shuttingdown) {
> // some error found in journal thread and it quits
> // following add operations to it would hang unit client timeout
> // so we should let bookie server exists
> LOG.error("Journal manager quits unexpectedly.");
> shutdown(ExitCode.BOOKIE_EXCEPTION);
> }{code}
> bookie thread is waiting at *this.join()* in below code
> {code}// Shutdown the ZK client
> if(zk != null) zk.close();
> // Shutdown journal
> journal.shutdown();
> this.join();
> syncThread.shutdown();
> // close Ledger Manager{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
