[
https://issues.apache.org/jira/browse/BOOKKEEPER-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13686268#comment-13686268
]
Sijie Guo commented on BOOKKEEPER-628:
--------------------------------------
thanks [~rakeshr]
since bookie registration involve zookeeper session expire handling, how you
could make it generic?
general comments on your patch:
1. please involve version in this interface. you could refere LedgerManager
interface.
2. this abstraction consider both client and server side change. so you need to
ensure client and bookie agrees on using same implementation of this interface.
check LedgerManagerFactory. it would be better to separate client-only,
server-only and common part into different interfaces and managed by one
factory.
> Improve bookie registration interface
> -------------------------------------
>
> Key: BOOKKEEPER-628
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-628
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-client, bookkeeper-server
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 4.3.0
>
> Attachments: BOOKKEEPER-628-interface-version.patch
>
>
> The idea is to improve/generalize the bookie registration process
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
