[
https://issues.apache.org/jira/browse/BOOKKEEPER-619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13688842#comment-13688842
]
Sijie Guo commented on BOOKKEEPER-619:
--------------------------------------
in general, it is good to have the checking. I agreed.
but the existence of ledgerRootPath doesn't mean the metadata is formatted. for
example, in a shared zookeeper environment, the ledgerRootPath might be
provided before bookkeeper initialized its instance. that's why I don't think
the patch is necessary, since the best guideline is when you format the
metadata instance, you'd better to format the bookies, no matter the bookie is
non-formatted, formatted from previous instance, or partial-formatted due to
incorrect steps.
anyway +1 for this patch.
> Bookie should not create local cookie files if zookeeper is uninitialized
> -------------------------------------------------------------------------
>
> Key: BOOKKEEPER-619
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-619
> Project: Bookkeeper
> Issue Type: Bug
> Affects Versions: 4.2.1
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.2, 4.3.0
>
> Attachments:
> 0001-BOOKKEEPER-619-Bookie-should-not-create-local-cookie.patch
>
>
> If you download a distribution of bookkeeper-4.2.1 and try to start the
> bookie before initializing zookeeper, then the bookie will fail to start, but
> write the local cookie files with a null instance id. If you then initialize
> zookeeper with the "bin/bookkeeper shell metaformat", you will not be able to
> start the bookie as instance id of in zk will not match the null instance id
> in the bookie files.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
