[
https://issues.apache.org/jira/browse/BOOKKEEPER-630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13688948#comment-13688948
]
Sijie Guo commented on BOOKKEEPER-630:
--------------------------------------
for indentation issue, how possible we would pull the changes for copy-paste
code? or how we would track the changes for the code we copied? In reality, if
we want to track upstream changes, it would be better to use package
dependency; when we copied the code, it means somehow we break the dependency
with upstream changes, we are already on the way to maintain even fix the part
of code. It is a tradeoff between porting code and include dependency. No
preference for me. If we agreed on copying the code, I prefer what Flavio said
for future changes.
If we agreed on copying code, I would suggest put in in net package rather than
util.net package.
> Resolve inconsistency between o.a.b.net.* and o.a.b.util.net.*
> --------------------------------------------------------------
>
> Key: BOOKKEEPER-630
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-630
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Flavio Junqueira
> Priority: Trivial
>
> We didn't reformat the code before bringing it in from hadoop commons in the
> patch of BOOKKEEPER-618.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
