[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13693561#comment-13693561
 ] 

Sijie Guo commented on BOOKKEEPER-629:
--------------------------------------

the patch looks fine. you also need to add backward compatible tests.

1. new version bookie starts with the cookies generated by old version.
2. old version bookie starts with the cookies generated by new version (with 
useHostName)
3. old client should works correctly if new bookie starts with useHostName
4. old client should read the ledger metadata written by new client with 
useHostName
                
> Support hostname based ledger metadata to help users to change IP with 
> exitsting installation
> ---------------------------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-629
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-629
>             Project: Bookkeeper
>          Issue Type: Improvement
>          Components: bookkeeper-client, bookkeeper-server
>    Affects Versions: 4.2.1, 4.3.0
>            Reporter: Vinay
>            Assignee: Rakesh R
>             Fix For: 4.3.0
>
>         Attachments: 1-BOOKKEEPER-629.patch, 2-BOOKKEEPER-629.patch, 
> 3-BOOKKEEPER-629.patch, 4-BOOKKEEPER-629.patch
>
>
> Register the bookie with *hostname:port* and also store the bookie addresses 
> as *hostname:port* in ledger metadata files instead of *ip:port*
> This will help users to change the machine IP if they want without loosing 
> their data.
> Supporting hostname based installation/functionality is one of the important 
> requirement of users.
> Any thoughts?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to