[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13737025#comment-13737025
 ] 

Ivan Kelly commented on BOOKKEEPER-632:
---------------------------------------

hey Vinay, really sorry about taking so long to get to this. Had a trip to the 
US last week, and previous weeks were eaten up preparing for it.

Regarding the patch, we don't want to expose zookeeper apis in our public apis, 
and BookKeeperAdmin#getAvailableBookies() is a public api. It would be better 
to add a new API, 
{code}
BookieWatcher#notifyBookiesChanged(BookiesListener listener);

interface BookiesListener {
    void availableBookiesChanged();
}
{code}

This way, BookKeeperAdmin isn't exposing anything new except for the 
#getReadOnlyBookies() api.
                
> AutoRecovery should consider read only bookies
> ----------------------------------------------
>
>                 Key: BOOKKEEPER-632
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-632
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: bookkeeper-auto-recovery, bookkeeper-server
>    Affects Versions: 4.2.1, 4.3.0
>            Reporter: Vinay
>            Assignee: Vinay
>             Fix For: 4.2.2, 4.3.0
>
>         Attachments: BOOKKEEPER-632-branch-4.2.patch, BOOKKEEPER-632.patch, 
> BOOKKEEPER-632.patch, BOOKKEEPER-632.patch, BOOKKEEPER-632.patch, 
> BOOKKEEPER-632.patch, BOOKKEEPER-632.patch
>
>
> Autorecovery Auditor should consider the readonly bookies as Available 
> Bookies  while publishing the under-replicated ledgers.
> Also AutoRecoveryDaemon should shutdown if the local bookie is readonly

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to