[
https://issues.apache.org/jira/browse/BOOKKEEPER-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13747432#comment-13747432
]
Hadoop QA commented on BOOKKEEPER-580:
--------------------------------------
Testing JIRA BOOKKEEPER-580
Patch
[0001-BOOKKEEPER-580-improve-close-logic.patch|https://issues.apache.org/jira/secure/attachment/12599409/0001-BOOKKEEPER-580-improve-close-logic.patch]
downloaded at Thu Aug 22 10:41:17 UTC 2013
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
120
. {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
{color:red}-1 TESTS{color}
. Tests run: 885
. Tests failed: 7
. Tests errors: 9
. The patch failed the following testcases:
.
testSyncUnsubscribeWithInvalidSubscriberId[1](org.apache.hedwig.server.integration.TestHedwigHubRegular)
.
testAsyncUnsubscribeWithInvalidSubscriberId[1](org.apache.hedwig.server.integration.TestHedwigHubRegular)
.
testSyncHubSubscribeWithInvalidSubscriberId[1](org.apache.hedwig.server.integration.TestHedwigHubRegular)
.
testAsyncHubSubscribeWithInvalidSubscriberId[1](org.apache.hedwig.server.integration.TestHedwigHubRegular)
.
testSyncHubUnsubscribeWithInvalidSubscriberId[1](org.apache.hedwig.server.integration.TestHedwigHubRegular)
.
testAsyncHubUnsubscribeWithInvalidSubscriberId[1](org.apache.hedwig.server.integration.TestHedwigHubRegular)
.
testPublishWithBookKeeperError[1](org.apache.hedwig.server.integration.TestHedwigHubRegular)
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/470/
> improve close logic
> -------------------
>
> Key: BOOKKEEPER-580
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-580
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-client
> Reporter: Sijie Guo
> Assignee: Ivan Kelly
> Fix For: 4.2.2, 4.3.0
>
> Attachments: 0001-BOOKKEEPER-580-improve-close-logic.patch,
> 0001-BOOKKEEPER-580-improve-close-logic.patch, BOOKKEEPER-580.diff,
> BOOKKEEPER-580.diff
>
>
> currently, bookkeeper client still write ledger metadata to metadata storage
> even the metadata is already closed or undergoing closing. which would cause
> lots of bad version metadata update encountering unrecoverable errors in
> ledger handle. e.g. NotEnoughtBookiesException.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira