[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13748768#comment-13748768
 ] 

Sijie Guo commented on BOOKKEEPER-654:
--------------------------------------

{quote}
-1 on the current patch. It doesn't handle the case where a client starts an 
async op and closes the bookkeeper client. In this case, the async op, when 
completed may try to add something to the executor and get a runtime exception. 
The cb will never be completed.
{quote}

this patch that Rakesh attached is trying to resolve this, which catch the 
exception and callback. I don't understand you meant.

for cancellable callback that you did, I am not sure that we really need it, 
since it would introduce an extra referencing on callbacks. if we didn't clean 
the callbacks in right way or in time (backing up due to slow requests), we 
might have gc issue.
                
> Bookkeeper client operations are allowed even after its closure, bk#close()
> ---------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-654
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-654
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: bookkeeper-client
>    Affects Versions: 4.2.0
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>             Fix For: 4.2.2, 4.3.0
>
>         Attachments: 
> 0001-BOOKKEEPER-654-Bookkeeper-client-operations-are-allo.patch, 
> 0001-BOOKKEEPER-654-testcase-to-understand-more.patch, 
> 0002-BOOKKEEPER-654.patch, 0003-BOOKKEEPER-654.patch, 
> 0004-BOOKKEEPER-654.patch, 0005-BOOKKEEPER-654.patch
>
>
> User can perform below operations with the closed bookkeeper client, which 
> was instantiated with external zkclient.
> - open a closed ledger 
> - create a new ledger 
> Also, ledgerhandle operations like fencing/add/write are infinitely hanging.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to