[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13761929#comment-13761929
 ] 

Hadoop QA commented on BOOKKEEPER-669:
--------------------------------------

Testing JIRA BOOKKEEPER-669


Patch 
[0001-BOOKKEEPER-669-race-between-evict-and-delete-ledger.patch|https://issues.apache.org/jira/secure/attachment/12602150/0001-BOOKKEEPER-669-race-between-evict-and-delete-ledger.patch]
 downloaded at Mon Sep  9 15:01:20 UTC 2013

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:green}+1{color} the patch does not introduce any line longer than 
120
.    {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1 FINDBUGS{color}
.    {color:green}+1{color} the patch does not seem to introduce new Findbugs 
warnings
{color:green}+1 TESTS{color}
.    Tests run: 878
{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:green}*+1 Overall result, good!, no -1s*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/bookkeeper-trunk-precommit-build/486/
                
> Race condition in ledger deletion and eviction from cache
> ---------------------------------------------------------
>
>                 Key: BOOKKEEPER-669
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-669
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: bookkeeper-server
>            Reporter: Matteo Merli
>            Assignee: Rakesh R
>             Fix For: 4.2.2
>
>         Attachments: 
> 0001-BOOKKEEPER-669-race-between-evict-and-delete-ledger.patch
>
>
> There is a race condition between when a ledger is delete and an eviction from
> LedgerCache occur.
> The resulting exception is:
> {code}
> 14:06:24.754 [SyncThread] ERROR org.apache.bookkeeper.bookie.Bookie  -
> Exception in SyncThread
> java.lang.NullPointerException: null
>         at
> org.apache.bookkeeper.bookie.LedgerCacheImpl.evictFileInfoIfNecessary(LedgerCacheImpl.java:809)
> ~[bookkeeper-server-4.2.1.15.jar:4.2.2-SNAPSHOT]
>         at
> org.apache.bookkeeper.bookie.LedgerCacheImpl.getFileInfo(LedgerCacheImpl.java:267)
> ~[bookkeeper-server-4.2.1.15.jar:4.2.2-SNAPSHOT]
>         at
> org.apache.bookkeeper.bookie.LedgerCacheImpl.flushLedger(LedgerCacheImpl.java:425)
> ~[bookkeeper-server-4.2.1.15.jar:4.2.2-SNAPSHOT]
>         at
> org.apache.bookkeeper.bookie.LedgerCacheImpl.flushLedger(LedgerCacheImpl.java:382)
> ~[bookkeeper-server-4.2.1.15.jar:4.2.2-SNAPSHOT]
>         at
> org.apache.bookkeeper.bookie.InterleavedLedgerStorage.flush(InterleavedLedgerStorage.java:167)
> ~[bookkeeper-server-4.2.1.15.jar:4.2.2-SNAPSHOT]
>         at org.apache.bookkeeper.bookie.Bookie$SyncThread.run(Bookie.java:330)
> ~[bookkeeper-server-4.2.1.15.jar:4.2.2-SNAPSHOT]
> 14:06:24.755 [SyncThread] INFO  org.apache.bookkeeper.bookie.Bookie  -
> Triggering shutdown of Bookie-3181 with exitCode 5
> 14:06:24.768 [BookieShutdownTrigger] INFO  
> org.apache.bookkeeper.bookie.Bookie 
> - Shutting down Bookie-3181 with exitCode 5
> 14:06:24.769 [BookieJournal-3181] WARN  org.apache.bookkeeper.bookie.Journal -
> Journal exits when shutting down
> {code}
> The problem is that the openLedger list is a normal LinkedList and sometimes 
> is
> modified while synchronizing on fileInfoCache, other times on openLedgers, and
> in other places it is accessed without synchronizing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to