[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13766648#comment-13766648
 ] 

Jiannan Wang commented on BOOKKEEPER-683:
-----------------------------------------

The sequence flow of test case 
TestSubAfterCloseSub#runSubAfterCloseSubTest(false) is as follow:
# subscriber.subscribe(topic, subid, CreateOrAttach.CREATE_OR_ATTACH);
# subscriber.asyncCloseSubscription(topic, subid, …)
# subscriber.asyncSubscribe(topic, subid, CreateOrAttach.ATTACH, …)

However, these two logs show that request (3) is handled before request (2) 
since it's sent in new channel:
{noformat}
2013-09-12 21:23:03,452 - INFO  - 
[DeliveryManagerThread:SubscribeHandler$1$1@206] - Subscribe request (1) for 
(topic:TestSubAfterCloseSub-false, subscriber:mysub) from channel 
/127.0.0.1:62996 succeed - its subscription data is State : { consumeSeqId: 
local:0 };Preferences : { System Preferences : [] };
2013-09-12 21:23:05,463 - INFO  - 
[DeliveryManagerThread:SubscribeHandler$1$1@206] - Subscribe request (2) for 
(topic:TestSubAfterCloseSub-false, subscriber:mysub) from channel 
/127.0.0.1:62997 succeed - its subscription data is State : { consumeSeqId: 
local:0 };Preferences : { System Preferences : [] };
{noformat}

As a result, the subscription is in closed state when message is published 
which cause test failure. With above description, it's reasonable that 
Non-MultiplexClient fail on this case.

@hustlmsp, the comment of the test case show that it's created for 
BOOKKEEPER-507. However, BOOKKEEPER-507 aims to fix race condition issue for 
multiplexed client. So my fix is just remove it, please notify me if a new case 
is required.
                
> TestSubAfterCloseSub fails on 4.2
> ---------------------------------
>
>                 Key: BOOKKEEPER-683
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-683
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Flavio Junqueira
>             Fix For: 4.2.2
>
>         Attachments: BOOKKEEPER-683.patch, 
> org.apache.hedwig.client.TestSubAfterCloseSub-output.txt, 
> org.apache.hedwig.client.TestSubAfterCloseSub.txt
>
>
> Test failure when checking the release candidate.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to