[
https://issues.apache.org/jira/browse/BOOKKEEPER-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13788933#comment-13788933
]
Sijie Guo commented on BOOKKEEPER-689:
--------------------------------------
[~fpj]
> Is this a blocker for the release?
I don't think it is the blocker of 4.2.0 release.
> Is there a valid reason for the close not to complete cleanly?
from the executor state, there is still an item in the queue but no thread in
pool to execute the item. so the awaitTerminate has to wait 10 seconds until
timeout. but it is clear that bookkeeper uses SafeRunnable, which means it
should not BookKeeper causing no thread in the pool. I am doubting this is
somehow a race in executor itself.
[~rakeshr]
> Does this induce any leaks or how long the shutdown will wait?
I don't think there is any leaks, since there is no thread in the pool. And
there is no referencing into the queuing item, so eventually all the items
would be gc'd after bookkeeper client instance is gc'd.
> BookKeeperTest failure
> ----------------------
>
> Key: BOOKKEEPER-689
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-689
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Flavio Junqueira
> Assignee: Sijie Guo
> Attachments: BOOKKEEPER-689.diff,
> org.apache.bookkeeper.client.BookKeeperTest-output.txt,
> TEST-org.apache.bookkeeper.client.BookKeeperTest.xml
>
>
> Tests run: 12, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 49.385 sec
> <<< FAILURE!
> testCloseDuringOp[1](org.apache.bookkeeper.client.BookKeeperTest) Time
> elapsed: 14.74 sec <<< FAILURE!
> junit.framework.AssertionFailedError: Close never completed
> at junit.framework.Assert.fail(Assert.java:47)
> at junit.framework.Assert.assertTrue(Assert.java:20)
> at
> org.apache.bookkeeper.client.BookKeeperTest.testCloseDuringOp(BookKeeperTest.java:217)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:601)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
> at
> org.junit.internal.runners.statements.FailOnTimeout$1.run(FailOnTimeout.java:28)
--
This message was sent by Atlassian JIRA
(v6.1#6144)
