[
https://issues.apache.org/jira/browse/BOOKKEEPER-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13807440#comment-13807440
]
Hadoop QA commented on BOOKKEEPER-602:
--------------------------------------
Testing JIRA BOOKKEEPER-602
Patch
[0001-BOOKKEEPER-602-we-should-have-request-timeouts-rathe.patch|https://issues.apache.org/jira/secure/attachment/12610664/0001-BOOKKEEPER-602-we-should-have-request-timeouts-rathe.patch]
downloaded at Mon Oct 28 22:26:39 UTC 2013
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
120
. {color:green}+1{color} the patch does adds/modifies 6 testcase(s)
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
{color:green}+1 TESTS{color}
. Tests run: 882
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:green}*+1 Overall result, good!, no -1s*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/514/
> we should have request timeouts rather than channel timeout in
> PerChannelBookieClient
> -------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-602
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-602
> Project: Bookkeeper
> Issue Type: Bug
> Affects Versions: 4.2.0, 4.2.1
> Reporter: Sijie Guo
> Assignee: Aniruddha
> Fix For: 4.3.0
>
> Attachments:
> 0001-BOOKKEEPER-602-we-should-have-request-timeouts-rathe.patch,
> BOOKKEEPER-602.diff, BOOKKEEPER-602.diff
>
>
> currently we only have readTimeout in netty channel, it timeouts only when
> there is no activities in that channel, but it can't track timeouts of
> individual requests. if a channel continues having read entry activities, it
> might shadow a slow add entry response, which is bad impacting add latency.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
