[
https://issues.apache.org/jira/browse/BOOKKEEPER-429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13809900#comment-13809900
]
Rakesh R commented on BOOKKEEPER-429:
-------------------------------------
Failure reason:- In the patch, its defined the number of worker threads to
zero. While creating threadpool by Journal, it passes this configured value to
the threadpool executor and is causing the exception. Is there any specific
reason to set the configuration as zero.
{code}
public SlowBookieTest() {
super(4);
+ baseConf.setNumAddWorkerThreads(0);
+ baseConf.setNumReadWorkerThreads(0);
}
{code}
Thread pool expects a non-zero +ve number. Otw will throw exception as follows:
{code}
ThreadPoolExecutor.java
if (corePoolSize < 0 ||
maximumPoolSize <= 0 ||
maximumPoolSize < corePoolSize ||
keepAliveTime < 0)
throw new IllegalArgumentException();
{code}
> Provide separate read and write threads in the bookkeeper server
> ----------------------------------------------------------------
>
> Key: BOOKKEEPER-429
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-429
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Affects Versions: 4.2.0
> Reporter: Aniruddha
> Assignee: Aniruddha
> Fix For: 4.3.0
>
> Attachments:
> 0001-BOOKKEEPER-429-Provide-separate-read-and-write-threa.patch,
> BK-429.patch, BOOKKEEPER-429.diff, BOOKKEEPER-429.diff
>
>
> The current bookkeeper server is single threaded. The same thread handles
> reads and writes. When reads are slow (possibly because of excessive seeks),
> add entry operations suffer in terms of latencies. Providing separate read
> and write threads helps in reducing add entry latencies and increasing
> throughput even when we're facing slow reads. Having a single read thread
> also results in low disk utilization because seeks can't be ordered
> efficiently by the OS. Multiple read threads would help in improving the read
> throughput.
> Discussion on this can be found at
> http://mail-archives.apache.org/mod_mbox/zookeeper-bookkeeper-dev/201209.mbox/%3ccaolhydqpzn-v10zynfwud_h0qzrxtmjgttx7a9eofohyyty...@mail.gmail.com%3e
> Reviewboard : https://reviews.apache.org/r/7560/
--
This message was sent by Atlassian JIRA
(v6.1#6144)
