[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13837316#comment-13837316
 ] 

Rakesh R commented on BOOKKEEPER-709:
-------------------------------------

Thank you Ivan, Flavio for the review.
bq.1.Is it still necessary to increase the sleep timeout to 3000?
I've increased the timeout, to give some more window period for the 
asyncAddEntry operation. I felt, 1sec is small period. I'd like to avoid hard 
coding, but couldn't see any parameter which can be used to relate this period.

bq.2.What's the rationale for getting the id but not using it?
Yeah correct, its not required and is unused. I will remove it.

> SlowBookieTest#testSlowBookie fails intermittently
> --------------------------------------------------
>
>                 Key: BOOKKEEPER-709
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-709
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>              Labels: tests
>             Fix For: 4.3.0
>
>         Attachments: 0001-BOOKKEEPER-709.patch, 0002-BOOKKEEPER-709.patch
>
>
> SlowBookieTest#testSlowBookie fails intermittently when verifying the result 
> of addEntry. 
> {code}
> junit.framework.AssertionFailedError: expected:<0> but was:<-559038737>
>       at junit.framework.Assert.fail(Assert.java:47)
>       at junit.framework.Assert.failNotEquals(Assert.java:283)
>       at junit.framework.Assert.assertEquals(Assert.java:64)
>       at junit.framework.Assert.assertEquals(Assert.java:195)
>       at junit.framework.Assert.assertEquals(Assert.java:201)
>       at 
> org.apache.bookkeeper.client.SlowBookieTest.testSlowBookie(SlowBookieTest.java:82)
>       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> {code}



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to