[
https://issues.apache.org/jira/browse/BOOKKEEPER-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13859829#comment-13859829
]
Rakesh R commented on BOOKKEEPER-661:
-------------------------------------
Good work Sijie:)
I've gone through 'back to writable logic' and please see the below comments.
I'll look into GC part separately and will add my comments to BOOKKEEPER-662.
# small typo : should be 'serve' instead of 'server'
{code}
LOG.info("Transitioning Bookie to Writable mode and will server read/write
requests.");
{code}
# small typo : should be 'Failed' instead of 'Faile'
{code}
LOG.warn("Faile to delete bookie readonly state in zookeeper : ", e);
{code}
# Wrongly deleting the readonly path, bookie is creating ephemral path as
follows. Please use the same for deletion
{code}
this.bookieRegistrationPath + BookKeeperConstants.READONLY + "/" + getMyId()
{code}
# Since it is ignoring the ZK KeeperException when deleting, its good to handle
KeeperException.NodeExistsException during transitionToReadOnlyMode() and here
it will triggerBookieShutdown()
{code}
// clear the readonly state
// ...
} catch (KeeperException e) {
// if we failed when deleting the readonly flag in zookeeper,
it is OK since client would
// already see the bookie in writable list. so just log the
exception
LOG.warn("Faile to delete bookie readonly state in zookeeper :
", e);
return;
}
{code}
-Rakesh
> Turn readonly back to writable if spaces are reclaimed.
> -------------------------------------------------------
>
> Key: BOOKKEEPER-661
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-661
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.3.0
>
> Attachments: BOOKKEEPER-661.diff
>
>
> should be able to turn a bookie from readonly back to writable if the spaces
> are reclaimed.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
