[
https://issues.apache.org/jira/browse/BOOKKEEPER-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13862497#comment-13862497
]
Rakesh R commented on BOOKKEEPER-644:
-------------------------------------
{quote}
I agreed that if it is a complicated feature-wise task, we should avoid doing
that. but for simple tasks like renaming, why not remove spaces & organizing
the imports when we touch those files.
{quote}
Makes sense to me.
It seems there is small conflicts in SlowBookieTest.java class due to the
latest checkins, please rebase it in latest trunk.
+1 looks nice and would like to appreciate the great effort. From my side just
a minor suggestion - while rebasing, please reuse the constant
BookKeeperConstants.COLON in BookieSocketAddress.java, instead of creating a
new constant again.
{code}
BookieSocketAddress.java
// Constants used by this class.
public static final String COLON = ":";
{code}
> Provide a bookie address wrapper
> --------------------------------
>
> Key: BOOKKEEPER-644
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-644
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-client, bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.3.0
>
> Attachments: BOOKKEEPER-644.diff, BOOKKEEPER-644.diff,
> BOOKKEEPER-644.diff, BOOKKEEPER-644.diff
>
>
> Provide bookie address wrapper for BOOKKEEPER-629, so client would use the
> address identifier by server w/o involving in deciding using ip or hostname.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
