-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17895/
-----------------------------------------------------------
(Updated April 21, 2014, 5:58 a.m.)
Review request for bookkeeper and Ivan Kelly.
Changes
-------
attach a new patch addressed comments
Bugs: BOOKKEEPER-582
https://issues.apache.org/jira/browse/BOOKKEEPER-582
Repository: bookkeeper-git
Description
-------
- introducing protobuf support for bookkeeper
- for server: introduce packet processor / EnDecoder for different protocol
supports
- for client: change PCBC to use protobuf to send requests
- misc changes for protobuf support
(bookie server is able for backward compatibility)
Diffs (updated)
-----
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/IndexInMemPageMgr.java
56487aa
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerChecker.java
28e23d6
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java
fb36b90
bookkeeper-server/src/main/java/org/apache/bookkeeper/processor/RequestProcessor.java
241f369
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieProtoEncoding.java
1154047
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieRequestHandler.java
b922a82
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieRequestProcessor.java
8155b22
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookkeeperProtocol.java
PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PacketProcessorBase.java
PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PacketProcessorBaseV3.java
PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
a10f7d5
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessor.java
PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessorV3.java
PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/WriteEntryProcessor.java
PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/WriteEntryProcessorV3.java
PRE-CREATION
bookkeeper-server/src/main/proto/BookkeeperProtocol.proto PRE-CREATION
bookkeeper-server/src/main/resources/findbugsExclude.xml 97a6156
bookkeeper-server/src/test/java/org/apache/bookkeeper/proto/TestProtoVersions.java
5fcc445
bookkeeper-server/src/test/java/org/apache/bookkeeper/replication/AuditorPeriodicCheckTest.java
3f8496f
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieClientTest.java
bc05229
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/TestBackwardCompat.java
8376b46
Diff: https://reviews.apache.org/r/17895/diff/
Testing
-------
unit tests. backward tests.
Thanks,
Sijie Guo
