[
https://issues.apache.org/jira/browse/BOOKKEEPER-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13984363#comment-13984363
]
Rakesh R commented on BOOKKEEPER-746:
-------------------------------------
Thanks [~ikelly] for the useful commands. I've few comments, please go through
below:
# Javadoc is missing
{code}
Iterator<Long> listLedgersToRereplicate();
{code}
# Not required to check the children of 'urL'. Can we have like:
{code}
if (c.startsWith("urL")) {
curBatch.add(getLedgerId(c));
} else {
String child = parent + "/" + c;
queue.add(child);
}
{code}
# For "listledgers"
a) small typo in getUsage(): "listsledger" -> "listledgers"
b) I've checked other commands, they are adding options to the usage, can we
have like ?
{code}
+ String getUsage() {
+ return "listledgers [-meta]";
+ }
{code}
# small typo: "(this may take along time)" -> (this may take a long time)
# ListLedgersCmd - I haven't executed, but when looking at md.serialize(), it
doesn't have ledgerid. IMHO we can print ledgerid and its metadata. Otw it may
mess up things no ?
{code}
System.out.println(new String(md.serialize(), UTF_8));
{code}
# Can we make the args optional for simpletest. Now its true
{code}
+ lOpts.addOption("e", "ensemble", true, "Ensemble size (default
3)");
+ lOpts.addOption("w", "writeQuorum", true, "Write quorum size
(default 2)");
+ lOpts.addOption("a", "ackQuorum", true, "Ack quorum size (default
2)");
+ lOpts.addOption("n", "numEntries", true, "Entries to write
(default 1000)");
{code}
# getUsage() of simpletest doesn't have options. It would be good to add
options too.
-Rakesh
> 5 new shell commands. List ledgers, list metadata, list underreplicated, show
> auditor and simpletest
> ----------------------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-746
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-746
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.3.0, 4.2.3
>
> Attachments:
> 0005-5-new-shell-commands.-List-ledgers-list-metada.trunk.patch,
> 0007-5-new-shell-commands.-List-ledgers-list-me.branch4.2.patch
>
>
> names are self explanatory.
> 1. list all the ledgers in the cluster
> 2. print the metadata for a ledger
> 3. list underreplicated ledgers
> 4. show the address of the auditor
> 5. simple test: create ledger, write to ledger, close ledger
--
This message was sent by Atlassian JIRA
(v6.2#6252)
