[
https://issues.apache.org/jira/browse/BOOKKEEPER-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14012633#comment-14012633
]
Ivan Kelly commented on BOOKKEEPER-751:
---------------------------------------
There's something strange with the change to errorOutPendingAdds. You left the
call to that which was inside the synchronized section. Also, doing this
outside of the lock is dangerous. What happens if you close the ledger with LAC
and then before you error out the pending adds, an add with entryid > LAC
completes and acknowledges to the client.
The rest of the patch looks good. All tests pass for me also.
> Ensure all the bookkeeper callbacks not run under ledger handle lock
> --------------------------------------------------------------------
>
> Key: BOOKKEEPER-751
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-751
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-client
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.3.0, 4.2.3
>
> Attachments: BOOKKEEPER-751.diff
>
>
> we are running bookkeeper callbacks under ledger handle lock, which would
> possibly introduce deadlock if application call bookkeeper functions in those
> callbacks.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
