[
https://issues.apache.org/jira/browse/BOOKKEEPER-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14062021#comment-14062021
]
Flavio Junqueira commented on BOOKKEEPER-582:
---------------------------------------------
bq. in zookeeper, EPHEMERAL / EPHEMERAL_SEQUENTIAL / PERSISTENT /
PERSISTENT_SEQUENTIAL are used for representing create mode. what do you think
about this? does it introduce any troubles in zookeeper for extension or
maintenance?
I think this has been mentioned before or possibly I thought of that and didn't
say it, but it is right that we do it in ZK. The difference is that those
aren't error codes and there are really only two options, ephemeral and
sequential. Those options have never changed, while I'd expect code error codes
to evolve. I still prefer to use enums over booleans, and I hope java
incorporates eventually this same flag feature for enums that C# has.
bq. the packet-level error isn't as what you described for server errors.
Ok, got it. I think calling it packet-level error is a bit confusing, though.
Just so that we come to a closure, based on all the comments, do you still feel
that this patch should go in unchanged or would you like to change anything?
> Make bookie and client use protobuf for requests (non-wire part)
> ----------------------------------------------------------------
>
> Key: BOOKKEEPER-582
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-582
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-client, bookkeeper-server
> Reporter: Ivan Kelly
> Assignee: Aniruddha
> Fix For: 4.3.0
>
> Attachments:
> 0002-BOOKKEEPER-582-Make-bookie-and-client-use-protobuf-f.patch,
> 0002-BOOKKEEPER-582-Make-bookie-and-client-use-protobuf-f.patch,
> 0002-BOOKKEEPER-582-Make-bookie-and-client-use-protobuf-f.patch,
> 0003-BOOKKEEPER-582-Make-bookie-and-client-use-protobuf-f.patch,
> BOOKKEEPER-582.diff, BOOKKEEPER-582.v2.diff, BOOKKEEPER-582.v3.diff
>
>
> Make the client and the bookie use protobufs internally. This is the first
> step to using protobufs on the wire, but for the moment, BookieRequestHandler
> decodes the old wire protocol into the protobuf messages. Once this is in,
> enabling on the wire will be very simple, and the old manual serialization
> can be made "legacy" (still supported, but deprecated).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
