[
https://issues.apache.org/jira/browse/BOOKKEEPER-697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14078060#comment-14078060
]
Sijie Guo commented on BOOKKEEPER-697:
--------------------------------------
{code}
I'm not sure what's going on with the use of NullStatsLogger in some
constructors.
{code}
The constructors with NullStatsLogger.INSTANCE are mostly for test cases. So I
don't need to check a lot of places in test cases due to constructor signature
changes. The server will construct with a StatsLogger instantiated by
StatsProvider (see #main function in BookieServer).
{code}
but a different test case. It doesn't like this patch is causing it, so the
tests might be a bit unstable with the recent changes
{code}
what test cases you observed? is it ReadOnlyBookieTest : BOOKKEEPER-774 ? or
MultipleThread**Test?
> stats collection on bookkeeper server
> -------------------------------------
>
> Key: BOOKKEEPER-697
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-697
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Aniruddha
> Fix For: 4.3.0
>
> Attachments: BOOKKEEPER-697.patch
>
>
> Stats collection on bookkeeper server.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
