[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082003#comment-14082003
]
Sijie Guo commented on BOOKKEEPER-773:
--------------------------------------
{quote}
change the bookie id and update it back to zookeeper to use same zk path.
I think this is not required and can be removed ?
{quote}
it is good to have to make sure a bookie couldn't start if it fails in the
middle of renaming cookie. changing the bookie id first would prevent a bookie
start since cookies will not match. it would remind people to finish renaming
cookie.
I would suggest not generating cookie from configuration. or at lease you
should verify the cookie matches the cookie you read from zookeeper before
setting new bookie id.
regarding the above comments, the flow looks good to me.
other comments on your patch:
- you should handle the case that the new cookie was already created in
zookeeper, in previous rename run. and added test case for it.
- incorrect option description: opts.addOption("l", "useHostNameAsBookieID",
true, "Ledger ID");
- I don't understand why you need to bump cookie version. there isn't cookie
format changes.
- why you need to test 3 bookies? why can't just test one bookie?
> Provide admin tool to rename bookie identifier in Cookies
> ---------------------------------------------------------
>
> Key: BOOKKEEPER-773
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-773
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 4.3.0
>
> Attachments: 001-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
> 002-BOOKKEEPER-773-rename-bookieid-in-cookies.patch
>
>
> The idea of this JIRA to implement a mechanism to efficiently rename the
> bookie identifier present in the Cookies. Cookie information will be present
> in:
> - ledger & journal directories in each Bookie server
> - cookies znode in ZooKeeper
--
This message was sent by Atlassian JIRA
(v6.2#6252)
