[
https://issues.apache.org/jira/browse/BOOKKEEPER-778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14124338#comment-14124338
]
Sijie Guo commented on BOOKKEEPER-778:
--------------------------------------
the patch looks good to me. +1.
[~fpj]
in the test case, the ledger is created with writeQuorumSize = 1. so each loop
is to test tryReadLastAddConfirmed when the bookie is down. the numEntries is
to ensure it covers ensembleSize.
> Flake in TestTryReadLastConfirmed
> ---------------------------------
>
> Key: BOOKKEEPER-778
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-778
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.3.0
>
> Attachments:
> 0001-BOOKKEEPER-778-Flake-in-TestTryReadLastConfirmed.patch,
> TEST-org.apache.bookkeeper.client.TestTryReadLastConfirmed.xml.fail1,
> TEST-org.apache.bookkeeper.client.TestTryReadLastConfirmed.xml.fail2,
> TEST-org.apache.bookkeeper.client.TestTryReadLastConfirmed.xml.fail3
>
>
> Logs attached.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
