João Abecasis wrote:
Joel de Guzman wrote:
João Abecasis wrote:
Hmm... Even so, it seems we should fix this, spirit::eol_p can handle
different line-endings pretty well. Are we opening files in binary
mode? If not, I'll check in the obvious fix.
Although it doesn't look like binary mode was the issue here, I checked
this in as well. There's no need to have the standard lib handle
line-endings when we're handling them too.
Agreed! Thanks in advance. Oh BTW, the unindent function is the
thing to look into.
Ah! Indeed, unindent was buggy, '\r' characters were slipping through.
It should be better now.
Oh cool! Thanks!
Hmmm... Giving it a second look, the unindent code still looks
dangerous. It assumes non-empty (code) lines have at least the same
*number* of whitespace characters (" \t") as the first line of the snippet.
Hmmm. Right. It should eat only spaces. Also, we should issue a
warning when we see a tab.
In the very least, we should check whether erased characters are
whitespace. (Is this behaviour documented?) Anyway, Joel, I'd like you
to give it a look, before I mess with it ;-)
I think your intuition is correct. Anyway, it's always safe to
test against "gold" to verify all code mods.
<<Hey, any news on the PP-iterator stuff? I'm almost about
ready to go into that>>
No news... which in this case is not exactly good news :-(
Well, just keeping you on your toes :-) I have an old version of
your include_iterator. Can I start with that? I really want to
kep the ball rolling ;)
Cheers!
--
Joel de Guzman
http://www.boost-consulting.com
http://spirit.sf.net
-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server.
Download it for free - -and be entered to win a 42" plasma tv or your very
own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php
_______________________________________________
Boost-docs mailing list
[email protected]
Unsubscribe and other administrative requests:
https://lists.sourceforge.net/lists/listinfo/boost-docs
