Hi Susinda, Thanks for the patch - I'll have a look at this today.
I'm not sure what you had in mind when you talked about taking advantage of the fix for bug 46207, but I'd like to continue on the path of using Xtext for defining expression grammars instead of going back to using the old, hard-coded XPath parser. Was this your intention also? Anyone else listening in on this mailing list, if you know of an existing XPath 1 and/or XPath 2 grammar available as EPL source, please let us know. Thanks, Bob ----- Original Message ----- > Hi Bob > I was able to fix the following issues. > 2. Context Menu is missing > 3. Variable Picker (Which comes when click the context menu) is missing > 4. XPath Expression auto fill functionality is not there. > I think this fix solves many usability issues we had when writing > expressions. > In my fix i have introduced context menu (in ExpressionSection class) which > enables cut, copy, paste and Variable Picker actions > and also enabled content assist for the StyledText. Following classes were > modified in the patch. > plugins/org.eclipse.bpel.ui.noEmbeddedEditors/src/org/eclipse/bpel/ui/contentassist/ExpressionContentAssistProcessor.java > plugins/org.eclipse.bpel.ui.noEmbeddedEditors/src/org/eclipse/bpel/ui/contentassist/ExpressionSourceViewerConfiguration.java > plugins/org.eclipse.bpel.ui.noEmbeddedEditors/src/org/eclipse/bpel/ui/properties/BPELPropertySection.java > plugins/org.eclipse.bpel.ui.noEmbeddedEditors/src/org/eclipse/bpel/ui/properties/ExpressionSection.java > I haven't done the fix for Expression Language' selection drop-down menu yet > since want to make sure whether this approach is ok. I'd like to contribute > this fix and would appreciate if someone could look at this fix and give me > some feedback. Here i 'm attaching the git diff of the patch. > Thanks > Susinda > On Wed, Apr 9, 2014 at 6:52 PM, Susinda < [email protected] > wrote: > > Hi Bob/Lorenzo > > > Cant we give a try with the fix mentioned in this bug[1], seems like it > > supports embedding editors inside another(composite). In that case we may > > not want to remove the embedded editors. > > > Please give me your thoughts and any guidelines, i'd like to tryout this > > approach. Your directions are highly appreciated. > > > [1] - https://bugs.eclipse.org/bugs/show_bug.cgi?id=46207 > > > Thanks > > > On Tue, Apr 8, 2014 at 12:17 PM, Lorenzo Bettini < > > [email protected] > > > wrote: > > > > On 08/04/2014 08:43, Susinda wrote: > > > > > > > Hi Bob > > > > > > > > > > > > > > Currently i do not have experience in Xtext and expression grammars > > > > etc, > > > > > > > however if this is needed i could have a look at those and start. But > > > > > > > what i was worrying about is other issue that you have reported in [1]. > > > > > > > As i can see we are stuck with the compile error in the > > > > EditorInViewSite > > > > > > > class in org.eclipse.bpel.common.ui.composite. This was due to the api > > > > > > > change introduced in eclipse Juno. I have few questions on this. > > > > > > > Does Lorenzo's patch fix this issue. If so can i have that patch to > > > > > > > tryout and have a look. > > > > > > From what I remember, yes, my patch also reintroduce the possibility of > > > > > > embedding a text editor (actually a text field), independently from > > > > > > Xtext. The main point is to NOT use an editor site, but a text field > > > > > > (again, if I remember correctly :) > > > > > > > Where can i found the latest (half completed) source (I'm using the > > > > > > > source @ http://git.eclipse.org/gitroot/bpel/org.eclipse.bpel.git but > > > > > > > that doesn't reflect such changes) > > > > > > > > > > > > > > Thanks > > > > > > > Susinda > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Apr 8, 2014 at 2:53 AM, Bob Brodt < [email protected] > > > > > > > <mailto: [email protected] >> wrote: > > > > > > > > > > > > > > Hi Susinda, > > > > > > > > > > > > > > Thanks for the offer to help - it is greatly appreciated :) > > > > > > > > > > > > > > The BPEL expression editor extension is currently half complete: > > > > > > > Xtext has been integrated into the project, but we are lacking the > > > > > > > expression grammars for XPath (and possibly XPath 2 and java). If > > > > > > > you have experience with Xtext and converting an abstract grammar > > > > > > > definition into one that can be parsed by Xtext, that would be a > > > > > > > great help and we can continue to move the project forward. > > > > > > > > > > > > > > Please let me know if you are willing/able to help in this capacity. > > > > > > > > > > > > > > Thanks, > > > > > > > Bob > > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------ > > > > > > > > > > > > > > Hi Bob > > > > > > > > > > > > > > Yes i'm willing to volunteer to fix this issue. If you could > > > > > > > give me some points on how/where to start, that would be easy > > > > > > > for me to give a quick start. > > > > > > > @ Lorenzo - Could you please provide me the link for your patch, > > > > > > > So i could start from your patch. > > > > > > > > > > > > > > Thanks all for all the inputs and responses. > > > > > > > > > > > > > > Susinda > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Sun, Apr 6, 2014 at 2:01 PM, Lorenzo Bettini > > > > > > > < [email protected] <mailto: [email protected] >> > > > > > > > wrote: > > > > > > > > > > > > > > Hi > > > > > > > > > > > > > > I don't know whether this is related but last year I > > > > > > > submitted a patch to renable the expression editor and also > > > > > > > to integrate Xtext languages... > > > > > > > > > > > > > > cheers > > > > > > > Lorenzo > > > > > > > > > > > > > > -- > > > > > > > Lorenzo Bettini, PhD in Computer Science, DI, Univ. Torino > > > > > > > HOME: http://www.lorenzobettini.it > > > > > > > Xtext Book: > > > > > > > http://www.packtpub.com/implementing-domain-specific-languages-with-xtext-and-xtend/book > > > > > > > < > > > > http://www.packtpub.com/implementing-domain-specific-languages-with-xtext-and-xtend/book > > > > > > > > > > > > > > > > > > > > > > > > > > On 4/4/2014 7:55 PM, Bob Brodt wrote: > > > > > > > > > > > > > > Hi Susinda, > > > > > > > > > > > > > > This is a significant rewrite and, unfortunately has > > > > > > > been put off > > > > > > > because of other ongoing work. We are looking for > > > > > > > volunteers to help > > > > > > > with this project, so if you or someone you know is > > > > > > > interested please > > > > > > > let me know ;) > > > > > > > I don't expect this enhancement to be available until > > > > > > > the Luna release > > > > > > > (June 25) or possibly later. > > > > > > > > > > > > > > Cheers, > > > > > > > Bob > > > > > > > > > > > > > > ________________________ > > > > > > > Robert ("Bob") Brodt > > > > > > > Senior Software Engineer > > > > > > > JBoss by Red Hat > > > > > > > > > > > > > > ------------------------------------------------------------------------ > > > > > > > > > > > > > > > > > > > > > Hi Andrej > > > > > > > > > > > > > > Thanks a lot for the quick response. I tried with > > > > > > > Kepler and BPEL > > > > > > > 1.0.3 and now i can see the editor. But following > > > > > > > parts and features > > > > > > > are missing > > > > > > > > > > > > > > 1. Expression Language' selection drop-down menu is > > > > > > > missing > > > > > > > 2. Context Menu is missing > > > > > > > 3. Variable Picker (Which comes when click the > > > > > > > context menu) is missing > > > > > > > 4. XPath Expression auto fill functionality is not > > > > > > > there. > > > > > > > > > > > > > > > > > > > > > > > > > > > > The readme file at > > > > > > > org.eclipse.bpel.ui.noEmbeddedEditors package > > > > > > > says following > > > > > > > > > > > > > > This plugin is essentially a duplicate of > > > > > > > org.eclipse.bpel.ui with > > > > > > > the embedded editor functionality removed. > > > > > > > This was necessary because of breaking > > > > > > > org.eclipse.ui API changes in > > > > > > > Eclipse Juno. > > > > > > > After this feature is rewritten to work with Juno, > > > > > > > this plugin must > > > > > > > be removed and the plugins/pom.xml restored to its > > > > > > > original. > > > > > > > > > > > > > > I think this is the reason for above (1, 2, 3, 4) > > > > > > > issues. I guess > > > > > > > this need to be properly fixed (i.e this feature is > > > > > > > rewritten) so > > > > > > > these issues will be fixed. > > > > > > > So what i wanted to ask is to know when this will be > > > > > > > fixed, is > > > > > > > anyone working on this or is there any patches etc. > > > > > > > > > > > > > > Thanks > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Fri, Apr 4, 2014 at 12:06 PM, Andrej Podhradsky > > > > > > > < [email protected] <mailto: [email protected] > > > > > > > > <mailto: [email protected] > > > > > > > <mailto: [email protected] >>> wrote: > > > > > > > > > > > > > > Hi Susinda, > > > > > > > > > > > > > > I recommend to use Eclipse Kepler for JEE > > > > > > > Develepers with BPEL > > > > > > > plugin of version 1.0.3. > > > > > > > If the problem is still present, could you > > > > > > > report a bug, please? > > > > > > > > > > > > > > Have a nice day! > > > > > > > > > > > > > > Andrej > > > > > > > > > > > > > > ----- Original Message ----- > > > > > > > From: "Susinda" < [email protected] > > > > > > > <mailto: [email protected] > <mailto: [email protected] > > > > > > > <mailto: [email protected] >>> > > > > > > > To: [email protected] > > > > > > > <mailto: [email protected] > > > > > > > > <mailto: [email protected] <mailto: [email protected] >> > > > > > > > Sent: Friday, April 4, 2014 7:37:21 AM > > > > > > > Subject: [bpel-dev] BPEL - Expression Editor is > > > > > > > not working, > > > > > > > How can we fix this > > > > > > > > > > > > > > Hi All > > > > > > > I tried to use an expression in assign activity, > > > > > > > but expression > > > > > > > editor is not loading so i could not give an > > > > > > > expression. > > > > > > > I have read your issue tracker[1] and googled > > > > > > > this issue and got > > > > > > > to know that this issue was because of the > > > > > > > org.eclipse.ui.internal.EditorSite class has > > > > > > > been removed when > > > > > > > eclipse goes to Juno. The mentioned fix @[1] has > > > > > > > removed the > > > > > > > expression editor totally therefore BPEL > > > > > > > Designer plugin > > > > > > > unusable in Eclipse Juno. > > > > > > > May i know when this will be fixed and Do u have > > > > > > > any releases > > > > > > > planned in near future in which this would be fixed. > > > > > > > Also i'd like to contribute to fix this issue, > > > > > > > in that case do > > > > > > > you have any guidelines that would be valuable > > > > > > > for me to > > > > > > > proceed. And i'd like to know if any patches > > > > > > > exists for this issue. > > > > > > > > > > > > > > Thanks > > > > > > > [1] - > > > > > > > https://bugs.eclipse.org/bugs/show_bug.cgi?id=378997 > > > > > > > < https://bugs.eclipse.org/bugs/show_bug.cgi?id=378997 > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > ********************************** > > > > > > > Susinda Perera > > > > > > > B.Sc. (Eng), AMIE(SL) > > > > > > > E-mail : [email protected] > > > > > > > <mailto: [email protected] > <mailto: [email protected] > > > > > > > <mailto: [email protected] >> > > > > > > > Voice : 0716049075 <tel: 0716049075 > > > > > > > > <tel: 0716049075 <tel: 0716049075 >> > > > > > > > > > > > > > > ********************************** > > > > > > > > > > > > > > _______________________________________________ > > > > > > > bpel-dev mailing list > > > > > > > [email protected] > > > > > > > <mailto: [email protected] > > > > > > > > <mailto: [email protected] <mailto: [email protected] >> > > > > > > > > > > > > > > > > > > > > > https://dev.eclipse.org/mailman/listinfo/bpel-dev > > > > > > > < https://dev.eclipse.org/mailman/listinfo/bpel-dev > > > > > > > > _______________________________________________ > > > > > > > bpel-dev mailing list > > > > > > > [email protected] > > > > > > > <mailto: [email protected] > > > > > > > > <mailto: [email protected] <mailto: [email protected] >> > > > > > > > > > > > > > > > > > > > > > https://dev.eclipse.org/mailman/listinfo/bpel-dev > > > > > > > < https://dev.eclipse.org/mailman/listinfo/bpel-dev > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > ********************************** > > > > > > > Susinda Perera > > > > > > > B.Sc. (Eng), AMIE(SL) > > > > > > > E-mail : [email protected] > > > > > > > <mailto: [email protected] > <mailto: [email protected] > > > > > > > <mailto: [email protected] >> > > > > > > > > > > > > > > Voice : 0716049075 <tel: 0716049075 > > > > > > > > ********************************** > > > > > > > > > > > > > > _______________________________________________ > > > > > > > bpel-dev mailing list > > > > > > > [email protected] <mailto: [email protected] > > > > > > > > https://dev.eclipse.org/mailman/listinfo/bpel-dev > > > > > > > < https://dev.eclipse.org/mailman/listinfo/bpel-dev > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > > > bpel-dev mailing list > > > > > > > [email protected] <mailto: [email protected] > > > > > > > > https://dev.eclipse.org/mailman/listinfo/bpel-dev > > > > > > > < https://dev.eclipse.org/mailman/listinfo/bpel-dev > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > > > bpel-dev mailing list > > > > > > > [email protected] <mailto: [email protected] > > > > > > > > https://dev.eclipse.org/mailman/listinfo/bpel-dev > > > > > > > < https://dev.eclipse.org/mailman/listinfo/bpel-dev > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > ********************************** > > > > > > > Susinda Perera > > > > > > > B.Sc. (Eng), AMIE(SL) > > > > > > > E-mail : [email protected] <mailto: [email protected] > > > > > > > > Voice : 0716049075 <tel: 0716049075 > > > > > > > > ********************************** > > > > > > > > > > > > > > _______________________________________________ > > > > > > > bpel-dev mailing list > > > > > > > [email protected] <mailto: [email protected] > > > > > > > > https://dev.eclipse.org/mailman/listinfo/bpel-dev > > > > > > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > > > bpel-dev mailing list > > > > > > > [email protected] <mailto: [email protected] > > > > > > > > https://dev.eclipse.org/mailman/listinfo/bpel-dev > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > ********************************** > > > > > > > Susinda Perera > > > > > > > B.Sc. (Eng), AMIE(SL) > > > > > > > E-mail : [email protected] <mailto: [email protected] > > > > > > > > Voice : 0716049075 > > > > > > > ********************************** > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > > > bpel-dev mailing list > > > > > > > [email protected] > > > > > > > https://dev.eclipse.org/mailman/listinfo/bpel-dev > > > > > > > > > > > > > -- > > > > > > Lorenzo Bettini, PhD in Computer Science, DI, Univ. Torino > > > > > > HOME: http://www.lorenzobettini.it > > > > > > Xtext Book: > > > > > > http://www.packtpub.com/implementing-domain-specific-languages-with-xtext-and-xtend/book > > > > > > _______________________________________________ > > > > > > bpel-dev mailing list > > > > > > [email protected] > > > > > > https://dev.eclipse.org/mailman/listinfo/bpel-dev > > > > > -- > > > ********************************** > > > Susinda Perera > > > B.Sc. (Eng), AMIE(SL) > > > E-mail : [email protected] > > > Voice : 0716049075 > > > ********************************** > > -- > ********************************** > Susinda Perera > B.Sc. (Eng), AMIE(SL) > E-mail : [email protected] > Voice : 0716049075 > ********************************** > _______________________________________________ > bpel-dev mailing list > [email protected] > https://dev.eclipse.org/mailman/listinfo/bpel-dev
_______________________________________________ bpel-dev mailing list [email protected] https://dev.eclipse.org/mailman/listinfo/bpel-dev
