I'm going to say right away that this patch won't be accepted. The development environment is friendly enough for us (I actually have no idea what it is you're trying to "fix" here), so unless somebody else argues convincingly in favour of your changes, I'm saying "no" to this patch. Any patch modifying `sys.path` is also almost certainly guaranteed to be rejected. I'd suggest focusing on adding missing features rather than trying to change bpython's architecture.
On 10 April 2011 10:27, anatoly techtonik <[email protected]> wrote: > On Sun, Apr 10, 2011 at 4:34 AM, Andreas Stührk > <[email protected]> wrote: >> >>> However, these scripts don't >>> work from checkout without setting PYTHONPATH properly. For fix this >>> problem I've patched data/* scripts to execute bpython directly from >>> checkout, so you may pull these changes from >>> https://bitbucket.org/techtonik/bpython >> >> Please don't try to mess around with sys.path. FWIW, I will never pull >> any change that does something like that. If you want to run bpython >> from a checkout, either set PYTHONPATH or use "python -m bpython.cli" >> (replace "cli" with "gtk_" or "urwid" if you want another UI). > > You can't use `python -m bpython.cli` without setting PYTHONPATH > unless you're at project root (which is not the case when you're > editing bpython files). You need to setup PYTHONPATH every time for > every clone (i.e. for every patch). The matters get worse if bpython > is already installed in site-packages, because if you forget to set > PYTHONPATH - everything will still work, except your changes. It is > not friendly development environment. > > What this patch does - > https://bitbucket.org/techtonik/bpython/changeset/07dce1fd4fee - is it > looks if current script is executed from `bpython` checkout and > adjusts the PYTHONPATH automatically. It looks if one of the parent > dir contain 'bpython' package (child dir named 'bpython' with > __init__.py in it) and adds this parent to sys.path. Then executes. > This guarantees that you work with the code base from checkout and not > from site-packages. > > -- > anatoly t. > > -- > You received this message because you are subscribed to the Google Groups > "bpython" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/bpython?hl=en. > > -- You received this message because you are subscribed to the Google Groups "bpython" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/bpython?hl=en.
