On Mon, 07 Jun 2010 14:50:48 -0500 Matt Mackall <[email protected]> wrote:
> On Mon, 2010-06-07 at 16:24 -0300, Flavio Leitner wrote: > > There are some networking drivers that hold a lock in the > > transmit path. Therefore, if a console message is printed > > after that, netconsole will push it through the transmit path, > > resulting in a deadlock. > > This is an ongoing pain we've known about since before introducing the > netpoll code to the tree. > > My take has always been that any form of queueing is contrary to the > goal of netpoll: timely delivery of messages even during machine-killing > situations like oopses. There may never be a second chance to deliver > the message as the machine may be locked solid. And there may be no > other way to get the message out of the box in such situations. Adding > queueing is a throwing-the-baby-out-with-the-bathwater fix. > > I think Dave agrees with me here, and I believe he's said in the past > that drivers trying to print messages in such contexts should be > considered buggy. > Because it to hard to fix all possible device configurations. There should be any way to detect recursion and just drop the message to avoid deadlock. -- _______________________________________________ Bridge mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/bridge
