On Thu, Mar 01, 2012 at 02:47:46PM +0530, santosh nayak wrote: > From: Santosh Nayak <[email protected]> > > Remove the redundant code. > > Signed-off-by: Santosh Nayak <[email protected]> > --- > net/bridge/netfilter/ebtables.c | 18 ++++++------------ > 1 files changed, 6 insertions(+), 12 deletions(-) > > diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c > index 9c0f177..1efc234 100644 > --- a/net/bridge/netfilter/ebtables.c > +++ b/net/bridge/netfilter/ebtables.c > @@ -226,10 +226,8 @@ unsigned int ebt_do_table (unsigned int hook, struct > sk_buff *skb, > > if (EBT_MATCH_ITERATE(point, ebt_do_match, skb, &acpar) != 0) > goto letscontinue; > - if (acpar.hotdrop) { > - read_unlock_bh(&table->lock); > - return NF_DROP; > - } > + if (acpar.hotdrop) > + goto out;
This is really broken! there's no "out" label in ebt_do_table as in the previous patch! _______________________________________________ Bridge mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/bridge
