On Wed, 29 May 2013 09:20:53 -0700 John Fastabend <[email protected]> wrote:
> Use IFLA_AF_SPEC nested attributes to lookup bridge mode and when > doing strcmp() check for equality. > > These appear to be typos from the original commit, > > commit 64108901b737b95247b53dec8c1b8217ca8505b7 > Author: Vlad Yasevich <[email protected]> > Date: Fri Mar 15 10:01:28 2013 -0700 > > bridge: Add support for setting bridge port attributes > > Also set flags to BRIDGE_FLAGS_SELF instead of using OR operation. > This allows setting the bridge mode when not being used with a > master device. > > To allow setting both master and self devices simultaneously we > will need to add a {self|master} field similar to fdb commands. > For now the command sets are mutually exclusive as noted in the > original commit. > > With this patch 'bridge link set' works now, > > # ./bridge/bridge link set dev veth1 cost 3 > # ./bridge/bridge link show > 10: veth1 state UP : <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 master > bridge0 state forwarding priority 3 cost 3 > > CC: Vlad Yasevich <[email protected]> > Signed-off-by: John Fastabend <[email protected]> Looks good, applied
