David Miller schreef op 21/05/2014 22:18:
From: Bart De Schuymer <[email protected]>
There's no reason why they should overlap in the cb: it's 48 bytes
big, so big enough to hold both struct br_input_skb_cb and struct
inet_skb_parm. The original problem was introduced when
BR_INPUT_SKB_CB was introduced (around Feb 27, 2010), so fixing
BR_INPUT_SKB_CB seems most appropriate to me.
So you are suggesting the patch below will fix everything?
Assuming:
- David Newall's worries about IPCB are incorrect
- you also revert the commit mentioned by David
(462fb2af9788a82a534f8184abfde31574e1cfa0 (bridge :
Sanitize skb before it enters the IP stack))
Then I give it a good chance the regression will be gone with your patch.
We never should have added bridging netfilter to the tree in the
first place, I wish I had better judgment back then.
Feel free to deprecate it. This is my last spare-time involvement.
Please apply following patch:
diff --git a/MAINTAINERS b/MAINTAINERS
index f5de16e..2369bae 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3163,10 +3163,9 @@ S: Maintained
F: drivers/scsi/eata_pio.*
EBTABLES
-M: Bart De Schuymer <[email protected]>
L: [email protected]
W: http://ebtables.sourceforge.net/
-S: Maintained
+S: Orphan
F: include/linux/netfilter_bridge/ebt_*.h
F: include/uapi/linux/netfilter_bridge/ebt_*.h
F: net/bridge/netfilter/ebt*.c
