On Mon, 13 Jan 2020 17:52:28 +0200, Nikolay Aleksandrov wrote:
> +static int br_vlan_rtm_dump(struct sk_buff *skb, struct netlink_callback *cb)
> +{
> + int idx = 0, err = 0, s_idx = cb->args[0];
> + struct net *net = sock_net(skb->sk);
> + struct br_vlan_msg *bvm;
> + struct net_device *dev;
> +
> + if (cb->nlh->nlmsg_len < nlmsg_msg_size(sizeof(*bvm))) {
I wonder if it'd be useful to make this a strict != check? At least
when strict validation is on? Perhaps we'll one day want to extend
the request?
> + NL_SET_ERR_MSG_MOD(cb->extack, "Invalid header for vlan dump
> request");
> + return -EINVAL;
> + }
