On Tue, Aug 10, 2021 at 02:00:10PM +0300, Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov <[email protected]> > > Ignore fdb flags when adding port extern learn entries and always set > BR_FDB_LOCAL flag when adding bridge extern learn entries. This is > closest to the behaviour we had before and avoids breaking any use cases > which were allowed. > > This patch fixes iproute2 calls which assume NUD_PERMANENT and were > allowed before, example: > $ bridge fdb add 00:11:22:33:44:55 dev swp1 extern_learn > > Extern learn entries are allowed to roam, but do not expire, so static > or dynamic flags make no sense for them. > > Also add a comment for future reference. > > Fixes: eb100e0e24a2 ("net: bridge: allow to add externally learned entries > from user-space") > Fixes: 0541a6293298 ("net: bridge: validate the NUD_PERMANENT bit when adding > an extern_learn FDB entry") > Reviewed-by: Ido Schimmel <[email protected]> > Tested-by: Ido Schimmel <[email protected]> > Signed-off-by: Nikolay Aleksandrov <[email protected]> > ---
Reviewed-by: Vladimir Oltean <[email protected]>
