On 16/08/2021 11:33, Dan Carpenter wrote: > Hi Nikolay, > > url: > https://github.com/0day-ci/linux/commits/Nikolay-Aleksandrov/net-bridge-mcast-dump-querier-state/20210813-230258 > base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git > b769cf44ed55f4b277b89cf53df6092f0c9082d0 > config: x86_64-randconfig-m001-20210814 (attached as .config) > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <[email protected]> > Reported-by: Dan Carpenter <[email protected]> > > smatch warnings: > net/bridge/br_multicast.c:2931 br_multicast_querier_state_size() warn: > sizeof(NUMBER)? > > vim +2931 net/bridge/br_multicast.c > > 384d7e0455593b Nikolay Aleksandrov 2021-08-13 2929 size_t > br_multicast_querier_state_size(void) > 384d7e0455593b Nikolay Aleksandrov 2021-08-13 2930 { > 384d7e0455593b Nikolay Aleksandrov 2021-08-13 @2931 return > nla_total_size(sizeof(0)) + /* nest attribute */ > > ^^^^^^^^^ > This looks like it's probably intentional, but wouldn't it be more > readable to say sizeof(int) as it does below? >
The nest attribute has 0 size, my error was the sizeof(0), where it should've been just 0 without sizeof. I'll send a fix, thank you for the report. > 384d7e0455593b Nikolay Aleksandrov 2021-08-13 2932 > nla_total_size(sizeof(__be32)) + /* BRIDGE_QUERIER_IP_ADDRESS */ > 384d7e0455593b Nikolay Aleksandrov 2021-08-13 2933 > nla_total_size(sizeof(int)) + /* BRIDGE_QUERIER_IP_PORT */ > 384d7e0455593b Nikolay Aleksandrov 2021-08-13 2934 > nla_total_size_64bit(sizeof(u64)); /* BRIDGE_QUERIER_IP_OTHER_TIMER */ > 384d7e0455593b Nikolay Aleksandrov 2021-08-13 2935 } > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/[email protected] >
