On Thu,  9 Feb 2023 09:18:51 +0200 Ido Schimmel wrote:
> +     if (nla_len(attr) != sizeof(struct br_mdb_entry)) {
> +             NL_SET_ERR_MSG_MOD(extack, "Invalid MDBA_SET_ENTRY attribute 
> length");
> +             return -EINVAL;

Well, you're just moving it, but NL_SET_ERR_MSG_ATTR() would be better.
We shouldn't be adding _MOD() in the core implementation of the family.

Reply via email to