On Thu, 14 Aug 2025 11:28:58 +0300 Ido Schimmel wrote:
> On Wed, Aug 13, 2025 at 05:20:17PM -0700, Jakub Kicinski wrote:
> > On Tue, 12 Aug 2025 11:02:12 +0300 Ido Schimmel wrote:
> > > /* redirect to backup link if the destination port is down */
> > > - if (rcu_access_pointer(to->backup_port) && !netif_carrier_ok(to->dev)) {
> > > + if (rcu_access_pointer(to->backup_port) &&
> > > + (!netif_carrier_ok(to->dev) || !netif_running(to->dev))) {
> >
> > Not really blocking this patch, but I always wondered why we allow
> > devices with carrier on in admin down state. Is his just something we
> > have because updating 200 drivers which don't manage carrier today
> > would be a PITA? Or there's a stronger reason to allow this?
> > Hopefully I'm not misreading the patch..
>
> Probably the first reason.
Thanks, let me add clearing carrier to our list of potential cleanup
projects.
