On 06/10/2024 20:24, Amedeo Baragiola wrote: > I agree, just patch actually changes the behaviour when a BR_FDB_LOCAL > dst is found and drops the traffic because promisc is *always* set to > false when a BR_FDB_LOCAL dst is found in br_handle_frame_finish(). > I guess the problem I was trying to solve was that since the > introduction of the promisc flag we still use brdev->flags & > IFF_PROMISC in br_pass_frame_up() which is essentially the value of > promisc (except in the BR_FDB_LOCAL case above) instead of promisc > itself. > > Amedeo > > [snip]
Please don't top post on netdev@. The current code works correctly, my question to Pablo was more about if the warn can still be triggered by adding a BR_FDB_LOCAL fdb and setting bridge promisc on, then we'll hit that codepath with promisc == false and it's kind of correct because traffic would've been passed up anyway, but the promisc flag can be actually set on the device.. Cheers, Nik
