Re: [PATCH net-next v3 07/10] net: ip: make ip_route_input_noref() return drop reasons

[Paolo Abeni]

On 10/15/24 16:07, Menglong Dong wrote:
> diff --git a/net/core/lwt_bpf.c b/net/core/lwt_bpf.c
> index e0ca24a58810..a4652f2a103a 100644
> --- a/net/core/lwt_bpf.c
> +++ b/net/core/lwt_bpf.c
> @@ -98,6 +98,7 @@ static int bpf_lwt_input_reroute(struct sk_buff *skb)
>               skb_dst_drop(skb);
>               err = ip_route_input_noref(skb, iph->daddr, iph->saddr,
>                                          ip4h_dscp(iph), dev);
> +             err = err ? -EINVAL : 0;

Please introduce and use a drop_reason variable here instead of 'err',
to make it clear the type conversion.

Thanks,

Paolo