Re: [Patch v4 net-next 1/3] net: bridge: mcast: Add offload failed mdb flag

[Jakub Kicinski]

On Tue, 8 Apr 2025 11:41:09 -0400 Joseph Huang wrote:
> -     if (err)
> -             goto err;
> +     if (err == -EOPNOTSUPP)
> +             goto notsupp;
>  
>       spin_lock_bh(&br->multicast_lock);
>       mp = br_mdb_ip_get(br, &data->ip);
> @@ -516,11 +516,12 @@ static void br_switchdev_mdb_complete(struct net_device 
> *dev, int err, void *pri
>            pp = &p->next) {
>               if (p->key.port != port)
>                       continue;
> -             p->flags |= MDB_PG_FLAGS_OFFLOAD;
> +
> +             br_multicast_set_pg_offload_flags(p, !err);
>       }
>  out:
>       spin_unlock_bh(&br->multicast_lock);
> -err:
> +notsupp:

One small nit, please name the jump label after the target, 
not the reason for the jump. So here "out_free" would be 
a good name.

>       kfree(priv);