On Thu, Sep 25, 2025 at 08:30:42PM +0200, Eric Woudstra wrote: > This adds the capability to conntrack 802.1ad, QinQ, PPPoE and PPPoE-in-Q > packets that are passing a bridge, only when a conntrack zone is set. > > Signed-off-by: Eric Woudstra <ericwo...@gmail.com> > --- > net/bridge/netfilter/nf_conntrack_bridge.c | 97 ++++++++++++++++++---- > 1 file changed, 80 insertions(+), 17 deletions(-) > > diff --git a/net/bridge/netfilter/nf_conntrack_bridge.c > b/net/bridge/netfilter/nf_conntrack_bridge.c > index 6482de4d8750..d3745af60f3a 100644 > --- a/net/bridge/netfilter/nf_conntrack_bridge.c > +++ b/net/bridge/netfilter/nf_conntrack_bridge.c > @@ -237,58 +237,121 @@ static int nf_ct_br_ipv6_check(const struct sk_buff > *skb) > return 0; > } > > +/** > + * nf_ct_bridge_pre_inner - advances network_header to the header that > follows > + * the pppoe- or vlan-header. > + */
Hi Eric, This is a Kernel doc. So please also document the function parameters. And the return value using "Return: " or "Returns: ". Likewise in patch 3/3. Flagged by ./scripts/kernel-doc -none -Wall Thanks! > + > +static int nf_ct_bridge_pre_inner(struct sk_buff *skb, __be16 *proto, u32 > *len) ...
