On Fri, 2 Oct 2026 23:09:56 +0300 Nikolay Aleksandrov wrote: > On 02/10/2026 22:45, Jakub Kicinski wrote: > > On Wed, 30 Sep 2026 10:14:00 +0300 Nikolay Aleksandrov wrote: > >> Add an opaque destination type and helpers for representing bridge port > >> destinations. Using a separate structure makes raw pointer assignments and > >> comparisons fail at build time while marking its value member __private > >> makes sparse warn about accesses that bypass the helpers. > > > > First time I'm seeing the __private thing. FTR feels quite foreign to C. > > __bitwise works very nicely for the same thing 🤷️ > > I don't mind switching to __bitwise, no preference here. I saw __private > initially > in the console code. It seems to be more restrictive (__bitwise allows direct > member > copies and comparisons, __private warns about those), but if __bitwise is > preferred > I can send a follow-up.
It's alright, mostly flagging for future reference. And I was curious how you chose it.
