On Fri, May 10, 2002 at 10:12:04AM -0700, Torrey Hoffman wrote:
> I've updated the AES encryption patch on my web page: > > http://www.arnor.net/encryptingbridge/index.html I've put the updated versions on bridge.sf.net/devel/bridge-crypt. > This is almost always not a problem, as the sk_buff's are usually > allocated with enough spare space at the end. But for some packets > (only small ones in my testing) there is not enough room at the end to > pad the packet. I'm still learning how this works, but I'm afraid it > may depend on the allocation strategy used by the underlying network > card driver. Yeah. For example, some cards have mini RX rings. Your best bet is probably to copy the entire sk_buff -- skb_copy_expand should work here. As the packets are small anyway, this shouldn't be a big problem. > I haven't decided the best approach to a proper fix, I suspect that > modifying the alloc_skb() and dev_alloc_skb() routines to always ensure > there's at least 16 bytes extra at the end of the buffer is the best way > to go. Please, don't do this. These routines are used by much more than the encrypting bridge code, and making such a system-wide API 'change' might subtly break a lot of things that you're not aware of right now. cheers, Lennert _______________________________________________ Bridge mailing list [EMAIL PROTECTED] http://www.math.leidenuniv.nl/mailman/listinfo/bridge
