On Friday 04 October 2002 16:28, Lennert Buytenhek wrote:
> On Thu, Oct 03, 2002 at 02:15:08PM +0200, Dominique Blas wrote:
> > Lennert, just to inform you
> > that I tested your patch and the phenomenom seems to have vanished.
>
> Thank you for testing.
>
> > BTW, what does exactly your patch ?
>
> Someone (forgot his name, sorry :) noticed that the skb->mac pointer
> does not always have to be valid, so sometimes we would overwrite
> random memory in __fixup_src_address (sp?). We write 8 bytes before
> skb->data (IP header pointer at that point) now, which should be
> safe.
Then we have 2 more bugs:
+ memcpy(skb->mac.ethernet->h_dest, dev->dev_addr, ETH_ALEN);
and
+ if (skb->mac.raw < skb->head || skb->mac.raw + ETH_HLEN > skb->data) {
We could ofcourse just set skb->mac to the right value, or does that give
issues?
--
cheers,
Bart
_______________________________________________
Bridge mailing list
[EMAIL PROTECTED]
http://www.math.leidenuniv.nl/mailman/listinfo/bridge
