On Sat, Feb 21, 2009 at 10:53:32PM +0000, Julien Levi wrote:
> Hello,
> 
> The prereq.sh script included with the xorcomm 
> bristuff-0.4.0-RC4-xr5.tar.gz release does not correctly check for 
> installed debian packages. At present the check_installed_rpms() 
> function returns a list of the already installed required packages 
> rather than the missing required packages. This causes the script to try 
> to reinstall packages that are already present and not install the 
> missing packages.
> 
> Line 62 is currently:
> 
>        | awk '/^[0-9]/{print $2}'
> 
> It should read (note the extra exclamation mark):
> 
>        | awk '!/^[0-9]/{print $2}'

Looks like the right place but not exactly the right fix. Indeed I have 
no idea why I asked aptitude for %V (the candidate version to install).
%c is the one-line "current status" character. I opted here to avoid
installed packages and also avoid virtual packages, as they will result
in an interactive installation, I suppose.

Try this:
--- prereq.sh   (revision 6586)
+++ prereq.sh   (working copy)
@@ -58,8 +58,8 @@
 # installed.
 check_installed_debs() {
        pattern=`for p in "$@"; do echo "~n^$p\$"; done`
-       aptitude search -F '%V %p' $pattern \
-       | awk '/^[0-9]/{print $2}'
+       aptitude search -F '%c %p' $pattern \
+       | awk '/^[cpuBCH]/{print $2}'
 }

 # parsing the output of yum is close to impossible.

-- 
               Tzafrir Cohen
icq#16849755              jabber:[email protected]
+972-50-7952406           mailto:[email protected]
http://www.xorcom.com  iax:[email protected]/tzafrir
_______________________________________________
Bristuff-users mailing list
[email protected]
http://lists.three-dimensional.net/mailman/listinfo/bristuff-users

Reply via email to