Revision: 41278
http://brlcad.svn.sourceforge.net/brlcad/?rev=41278&view=rev
Author: brlcad
Date: 2010-11-08 15:58:42 +0000 (Mon, 08 Nov 2010)
Log Message:
-----------
richard made a change that fixed a problem and causes a problem, so document it
as a FIXME. the memory needs to be released properly and/or the memory
management expectations of nmg_je() needs to be documented. just removing the
free is a memory leak.
Modified Paths:
--------------
brlcad/trunk/src/librt/primitives/nmg/nmg_mk.c
Modified: brlcad/trunk/src/librt/primitives/nmg/nmg_mk.c
===================================================================
--- brlcad/trunk/src/librt/primitives/nmg/nmg_mk.c 2010-11-08 15:54:07 UTC
(rev 41277)
+++ brlcad/trunk/src/librt/primitives/nmg/nmg_mk.c 2010-11-08 15:58:42 UTC
(rev 41278)
@@ -2876,6 +2876,12 @@
eusrc->radial_p->radial_p = eusrc_mate->radial_p;
eusrc_mate->radial_p->radial_p = eusrc->radial_p;
} else {
+ /* FIXME: this used to call FREE_EDGE() here but is now a
+ * potential memory leak. need to evaluate callers of
+ * nmg_je() to make sure they are managing memory release
+ * properly and/or re-add release of memory in here if needed.
+ */
+
/* this is the only use of the eusrc edge. kill/free edge but not
* here. the edge should be freed by the calling function which can
* determine this edge should be freed by its edgeuse pointer
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
------------------------------------------------------------------------------
The Next 800 Companies to Lead America's Growth: New Video Whitepaper
David G. Thomson, author of the best-selling book "Blueprint to a
Billion" shares his insights and actions to help propel your
business during the next growth cycle. Listen Now!
http://p.sf.net/sfu/SAP-dev2dev
_______________________________________________
BRL-CAD Source Commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/brlcad-commits
