Revision: 41456
http://brlcad.svn.sourceforge.net/brlcad/?rev=41456&view=rev
Author: indianlarry
Date: 2010-11-24 13:19:42 +0000 (Wed, 24 Nov 2010)
Log Message:
-----------
Removed the IsValid() check in the curve Split() function. This was causing
problems upstream in the surface splitting routines when trying to split
surface containing singularities. This problem was reported to the opennurbs
folks who have identified this as a bug and should be fix that should be in the
next release of the open tool kit.
Modified Paths:
--------------
brlcad/trunk/src/other/openNURBS/opennurbs_nurbscurve.cpp
Modified: brlcad/trunk/src/other/openNURBS/opennurbs_nurbscurve.cpp
===================================================================
--- brlcad/trunk/src/other/openNURBS/opennurbs_nurbscurve.cpp 2010-11-23
20:21:39 UTC (rev 41455)
+++ brlcad/trunk/src/other/openNURBS/opennurbs_nurbscurve.cpp 2010-11-24
13:19:42 UTC (rev 41456)
@@ -2931,8 +2931,17 @@
if ( left_crv && !ON_NurbsCurve::Cast(left_crv) )
return false;
if ( right_crv && !ON_NurbsCurve::Cast(right_crv) )
- return false;
- if ( IsValid() && t > m_knot[m_order-2] && t < m_knot[m_cv_count-1] )
+ return false;
+//
+// the IsValid() check in the following condition causes surface splitting
+// routines to fail on surface containing singularities. This problem has
+// been reported to the opennurbs folks who have identified this as a bug and
+// have a fix that should be in the next release (Rhino 5.0).See thread at:
+//
+//
http://news2.mcneel.com/scripts/dnewsweb.exe?utag=&group=opennurbs&xrelated=2342&cmd_related=View+thread
+//
+// was: if ( IsValid() && t > m_knot[m_order-2] && t < m_knot[m_cv_count-1] )
+ if ( t > m_knot[m_order-2] && t < m_knot[m_cv_count-1] )
{
ON_NurbsCurve* left = (ON_NurbsCurve*)left_crv;
ON_NurbsCurve* right = (ON_NurbsCurve*)right_crv;
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
------------------------------------------------------------------------------
Increase Visibility of Your 3D Game App & Earn a Chance To Win $500!
Tap into the largest installed PC base & get more eyes on your game by
optimizing for Intel(R) Graphics Technology. Get started today with the
Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs.
http://p.sf.net/sfu/intelisp-dev2dev
_______________________________________________
BRL-CAD Source Commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/brlcad-commits
